Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@storybook/addon-storysource #4

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

abernier
Copy link
Member

Why / What

Adding @storybook/addon-storysource to have that "Story" tab

image

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 8b596f9:

Sandbox Source
nice-moon-lsplsu Configuration
Ground reflections and video textures Configuration
arc-x-pmndrs-colors Configuration

@vis-prime
Copy link
Collaborator

@abernier can you remove the actions tab and add the story section again ?

@abernier
Copy link
Member Author

abernier commented May 16, 2023

@vis-prime what about upgrading to sb7 instead? I've set it up for pmndrs/react-postprocessing#202 (from scratch) and pmndrs/drei#1450 (migration - not yet merged).

Maybe you could replicate for drei-vanilla?

@vis-prime
Copy link
Collaborator

vis-prime commented May 16, 2023

@abernier oh yeah, i've been getting
yeaa
react-postprocessing version looks cool

I can just follow the instructions they provide ?

@abernier
Copy link
Member Author

I can just follow the instructions they provide ?

you can, but I didn't find their migration script that useful: especially, it configured sb7 with @storybook/react-webpack framework while I wanted @storybook/react-vite: I add to uninstall and re-install it manually.

If I were you, I would just "copy" that diff https://github.com/pmndrs/drei/pull/1450/files :)

@vis-prime
Copy link
Collaborator

I can just follow the instructions they provide ?

you can, but I didn't find their migration script that useful: especially, it configured sb7 with @storybook/react-webpack framework while I wanted @storybook/react-vite: I add to uninstall and re-install it manually.

If I were you, I would just "copy" that diff https://github.com/pmndrs/drei/pull/1450/files :)

uninstall/ install wasn't playing nicely so i just deleted the node modules folder

edited package.json with the same versions

did npm install --legacy-peer-deps

and then

npm run storybook
i get this error
'NODE_OPTIONS' is not recognized as an internal or external command, operable program or batch file.

what's NODE_OPTIONS ? i should be able to run preview the storybook locally right ?

@abernier
Copy link
Member Author

abernier commented May 24, 2023

this NODE_OPTIONS env var was added recently in drei for node 18 support: pmndrs/drei#1424

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants