Add support for Teknic ClearCore

[patrickwasp]

Closes #175.

[maxgerhardt]

You don't need this line because the code below it that checks for "is there a build.variant and if yes add it to the cpp path" already takes care of this:

platform-atmelsam/builder/frameworks/arduino/arduino-samd.py

Lines 214 to 221 in 1718730

	if "build.variant" in board:
	variants_dir = os.path.join(
	"$PROJECT_DIR", board.get("build.variants_dir")) if board.get(
	"build.variants_dir", "") else os.path.join(FRAMEWORK_DIR, "variants")
	env.Append(
	CPPPATH=[os.path.join(variants_dir, board.get("build.variant"))]
	)

[patrickwasp]

Just to be clear, the only line I don't need is 191? Or also the two first arduino lines?

so, this would be the result:

CPPPATH=[
    os.path.join(FRAMEWORK_DIR, "cores", "arduino", "api"),
    os.path.join(FRAMEWORK_DIR, "cores", "arduino"),
    os.path.join(FRAMEWORK_DIR, "Teknic", "LwIP", "LwIP", "port", "include"),
    os.path.join(FRAMEWORK_DIR, "Teknic", "LwIP", "LwIP", "src", "include"),
    os.path.join(FRAMEWORK_DIR, "Teknic", "libClearCore", "inc")
],

[maxgerhardt]

Correct, only os.path.join(FRAMEWORK_DIR, "variants", "clearcore"), is not needed.

[maxgerhardt]

Also: Your changes can be automatically verified to be compiling successfully on all architectures if you add an environment for your board in one of the examples, e.g., to examples/arduino-blink/platformio.ini at the bottom:

[env:clearcore]
platform = atmelsam
board = clearcore
framework = arduino

This example gets auto-compiled in the Github CI (see .github/workflows).

[maxgerhardt]

Can you go in your repo's https://github.com/patrickwasp/platform-atmelsam/actions and click activate? You should get compile feedback then (because CI will only run here after someone approves it)

[patrickwasp]

Can you go in your repo's https://github.com/patrickwasp/platform-atmelsam/actions and click activate? You should get compile feedback then (because CI will only run here after someone approves it)

I enabled it but the git action doesn't have workflow_dispatch so I can't manually run it.

[maxgerhardt]

It should automatically triger in each commit (after it's been enabled), so the next commit will trigger it.

Something that'll come up in review is also that last empty line was removed

(both .ini and in the arduino py file.). So you can just add another empty newline at the end of those files and commit that. (Somtimes you have to put two empty newlines because git likes to strip one)

[maxgerhardt]

Very nice, it built the clearcore firmware in the CI succesfully: https://github.com/patrickwasp/platform-atmelsam/actions/runs/6001903149/job/16277089103

I oversaw the missing newline end in the boards/clearcore.json though, but that'll all then.

[maxgerhardt]

All requested changes made and CI passes.

[CiberNin]

Is there anything holding this PR back?

Arduino just dropped support for its VSCode extension, so there's a bit more demand for this package to support the board.