Corrected FA components. Added html tag to disable eslinter mixed v-i… #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coffeeneed
reviewed
May 14, 2023
| @@ -14,7 +13,7 @@ | |||
| aria-expanded="false" | |||
| > | |||
| <span class="badge badge-pill badge-light">{{cartQty}}</span> | |||
| <i class="fas fa-shopping-cart mx-2"></i> | |||
| <font-awesome-icon icon="shopping-cart" class="mx-2"></font-awesome-icon> | |||
There was a problem hiding this comment.
This looks good. Nothing wrong with this, but could be written as <font-awesome-icon icon="shopping-cart" class="mx-2" /> I guess. Personal preference.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Navbar.vue
Line 5 deleted unused font awesome icon (dollar sign).
Line 16 replaced font awesome
<i>tag with component (cart icon).ProductList.vue
Added HTML comment tag to disable selective eslint rules. Was preventing compilation.