#10480 Submission stages property to array

pkp · Oct 17, 2024 · 9ba4db5 · 9ba4db5
1 parent 4d26bcd
commit 9ba4db5
Showing 1 changed file with 2 additions and 7 deletions.
diff --git a/classes/submission/maps/Schema.php b/classes/submission/maps/Schema.php
@@ -555,11 +555,6 @@ protected function getPropertyStages(Enumerable $stageAssignments, Submission $s
                 'isDecidingEditorAssigned' => false,
                 'isCurrentUserDecidingEditor' => false,
             ];
-
-            // Only for the review stages
-            if (in_array($stageId, [WORKFLOW_STAGE_ID_EXTERNAL_REVIEW, WORKFLOW_STAGE_ID_INTERNAL_REVIEW])) {
-                $stages[$stageId]['currentUserRecommendation'] = true;
-            }
         }
 
         $recommendations = [];
@@ -613,7 +608,7 @@ protected function getPropertyStages(Enumerable $stageAssignments, Submission $s
                     continue;
                 }
 
-                $stages[$groupStage->stageId]['roles'] = [
+                $stages[$groupStage->stageId]['currentUserAssignedRoles'] = [
                     $userGroup->getRoleId(),
                 ];
 
@@ -746,7 +741,7 @@ protected function getPropertyStages(Enumerable $stageAssignments, Submission $s
             }
         }
 
-        return $stages;
+        return array_values($stages);
     }
 
     /**