Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support other integer types for SubstringUTF8 & RightUTF8 functions #9507

Merged
merged 7 commits into from
Oct 10, 2024
Merged

Support other integer types for SubstringUTF8 & RightUTF8 functions #9507

merged 7 commits into from
Oct 10, 2024

Conversation

gengliqi
Copy link
Contributor

@gengliqi gengliqi commented Oct 10, 2024 •
edited
Loading

What problem does this PR solve?

Issue Number: close #9473

Problem Summary:

What is changed and how it works?

Support other integer types for SubstringUTF8 & RightUTF8 functions

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@gengliqi
fix substring & right
587e0f9 
Signed-off-by: gengliqi <gengliqiii@gmail.com>
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-triage-completed release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed do-not-merge/needs-triage-completed labels Oct 10, 2024
@gengliqi
Copy link
Contributor Author

/check-issue-triage-complete

@gengliqi gengliqi changed the title Support other integer types for SubstringUTF8 & right Support other integer types for SubstringUTF8 & Right functions Oct 10, 2024
@gengliqi gengliqi changed the title Support other integer types for SubstringUTF8 & Right functions Support other integer types for SubstringUTF8 & RightUTF8 functions Oct 10, 2024
@gengliqi
add test
d5a0423 
Signed-off-by: gengliqi <gengliqiii@gmail.com>
@gengliqi
remove out-of-date comments
6ba442f 
Signed-off-by: gengliqi <gengliqiii@gmail.com>
yibin87
yibin87 reviewed Oct 10, 2024
View reviewed changes
Copy link
Contributor

@yibin87 yibin87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Others LGTM

@gengliqi
address comments
91fa434 
Signed-off-by: gengliqi <gengliqiii@gmail.com>
yibin87
yibin87 approved these changes Oct 10, 2024
View reviewed changes
Copy link
Contributor

@yibin87 yibin87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Oct 10, 2024
windtalker
windtalker approved these changes Oct 10, 2024
View reviewed changes
Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: windtalker, yibin87

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 10, 2024
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 10, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-10-10 08:26:03.181929073 +0000 UTC m=+1120918.602142085: ☑️ agreed by yibin87.
  • 2024-10-10 08:43:48.991515584 +0000 UTC m=+1121984.411728596: ☑️ agreed by windtalker.

@gengliqi
u
9c0df58 
Signed-off-by: gengliqi <gengliqiii@gmail.com>
@gengliqi
fix left test
72edd71 
Signed-off-by: gengliqi <gengliqiii@gmail.com>
@ti-chi-bot ti-chi-bot bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Oct 10, 2024
@ti-chi-bot ti-chi-bot bot merged commit 9f85bb2 into pingcap:master Oct 10, 2024
5 checks passed
@gengliqi gengliqi added needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. labels Oct 10, 2024
@gengliqi
Copy link
Contributor Author

/run-cherry-picker

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #9510.

@ti-chi-bot ti-chi-bot mentioned this pull request Oct 10, 2024
Merged
12 tasks
ti-chi-bot pushed a commit to ti-chi-bot/tiflash that referenced this pull request Oct 10, 2024
@gengliqi @ti-chi-bot
This is an automated cherry-pick of pingcap#9507
787380d 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.1: #9511.

ti-chi-bot pushed a commit to ti-chi-bot/tiflash that referenced this pull request Oct 10, 2024
@gengliqi @ti-chi-bot
This is an automated cherry-pick of pingcap#9507
23398ad 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Oct 10, 2024
Open
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #9512.

@ti-chi-bot ti-chi-bot mentioned this pull request Oct 10, 2024
Open
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #9513.

ti-chi-bot pushed a commit to ti-chi-bot/tiflash that referenced this pull request Oct 10, 2024
@gengliqi @ti-chi-bot
This is an automated cherry-pick of pingcap#9507
d05043f 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Oct 10, 2024
Merged
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #9514.

@ti-chi-bot ti-chi-bot mentioned this pull request Oct 10, 2024
Open
12 tasks
ti-chi-bot pushed a commit to ti-chi-bot/tiflash that referenced this pull request Oct 10, 2024
@gengliqi @ti-chi-bot
This is an automated cherry-pick of pingcap#9507
7d57f0d 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-5.4: #9515.

@ti-chi-bot ti-chi-bot mentioned this pull request Oct 10, 2024
Open
12 tasks
ti-chi-bot bot pushed a commit that referenced this pull request Oct 10, 2024
@ti-chi-bot @gengliqi
Support other integer types for SubstringUTF8 & RightUTF8 functions (#…
8534177 
…9507) (#9510)

close #9473

Support other integer types for SubstringUTF8 & RightUTF8 functions

Signed-off-by: gengliqi <gengliqiii@gmail.com>

Co-authored-by: gengliqi <gengliqiii@gmail.com>
@gengliqi gengliqi added the needs-cherry-pick-release-8.4 Should cherry pick this PR to release-8.4 branch. label Oct 11, 2024
@gengliqi
Copy link
Contributor Author

/run-cherry-picker

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.4: #9516.

@ti-chi-bot ti-chi-bot mentioned this pull request Oct 11, 2024
Closed
12 tasks
gengliqi added a commit to ti-chi-bot/tiflash that referenced this pull request Nov 5, 2024
@gengliqi
Support other integer types for SubstringUTF8 & RightUTF8 functions (p…
4c87257 
…ingcap#9507)

Signed-off-by: gengliqi <gengliqiii@gmail.com>
ti-chi-bot bot pushed a commit that referenced this pull request Nov 5, 2024
@ti-chi-bot @gengliqi
Support other integer types for SubstringUTF8 & RightUTF8 functions (#…
ba9fab8 
…9507) (#9513)

close #9473

Support other integer types for SubstringUTF8 & RightUTF8 functions

Signed-off-by: gengliqi <gengliqiii@gmail.com>

Co-authored-by: Liqi Geng <gengliqiii@gmail.com>
Co-authored-by: gengliqi <gengliqiii@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yibin87 yibin87 yibin87 approved these changes

@windtalker windtalker windtalker approved these changes

Assignees
No one assigned
Labels
approved lgtm needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-8.4 Should cherry pick this PR to release-8.4 branch. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SubstringUTF8 & RightUTF8 do not support length of integer types other than int64/uint64
4 participants
@gengliqi @ti-chi-bot @windtalker @yibin87