lightning: add precheck that PD and TiDB must belongs to same cluster

[lance6716]

What problem does this PR solve?

Issue Number: close #57704

Problem Summary:

What changed and how does it work?

lance6716
summarize the file changed of this PR. No need to mention the details like filename or number of lines changed, just from logical and abstract view to write a summary.

Copilot
The changes in PR #57709 for the pingcap/tidb repository include adding a precheck function to ensure that PD and TiDB belong to the same cluster. This new validation logic is integrated into the existing precheck mechanisms within the lightning package.

Check List

Tests

• Unit test
• Integration test: CI failed when I forgot to strip the URL scheme
• Manual test (add detailed scripts or steps below)
• No need to test

  • I checked and no code files have been changed.

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

[tiprow]

Hi @lance6716. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[codecov]

Codecov Report

Attention: Patch coverage is 56.45161% with 27 lines in your changes missing coverage. Please review.

Project coverage is 73.7201%. Comparing base (d02d48a) to head (5b29952).
Report is 10 commits behind head on master.

Additional details and impacted files

@@               Coverage Diff                @@
##             master     #57709        +/-   ##
================================================
+ Coverage   72.8318%   73.7201%   +0.8883%     
================================================
  Files          1677       1707        +30     
  Lines        463944     475791     +11847     
================================================
+ Hits         337899     350754     +12855     
+ Misses       105169     103473      -1696     
- Partials      20876      21564       +688     

Flag	Coverage Δ
integration	46.1493% <56.4516%> (?)
unit	72.2361% <ø> (+0.0123%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	52.7673% <ø> (ø)
parser	∅ <ø> (∅)
br	45.1571% <ø> (-0.3541%)	⬇️

[lance6716]

/retest

[tiprow]

@lance6716: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[lance6716]

/retest

[tiprow]

@lance6716: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[wuhuizuo]

/retest

[tiprow]

@wuhuizuo: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[D3Hunter]

please comment that there will be false positive if user configs a LB address

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: D3Hunter

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [D3Hunter]
• lightning/OWNERS [D3Hunter]
• pkg/lightning/OWNERS [D3Hunter]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ti-chi-bot]

[LGTM Timeline notifier]

Timeline:

• 2024-11-27 06:44:31.439505657 +0000 UTC m=+618859.059160172: ☑️ agreed by D3Hunter.