Disable automaxprocs log #13800
Merged
Disable automaxprocs log #13800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: tennix <ztennix@gmail.com>
|
/run-check_dev |
|
/bench +tpch |
Benchmark Report
@@ Benchmark Diff @@
================================================================================
--- tidb: 18fbe2d483dbbf8bdea4735e579d7914ebc8ac42
+++ tidb: f20fa88ce4b1c298df4756d2c1589737278299e7
tikv: 61af99da5a3760b4a4ae8c432e1b7953e10531c2
pd: be73a29742cf3cc8d7cc401e169372254ca12bcb
================================================================================
10.sql duration: 9882.88 ms ± 3.15% (std=224.72) delta: 0.88% (p=0.313) |
Signed-off-by: tennix <ztennix@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #13800 +/- ##
===========================================
Coverage 80.1665% 80.1665%
===========================================
Files 474 474
Lines 117075 117075
===========================================
Hits 93855 93855
Misses 15820 15820
Partials 7400 7400 |
jackysp
approved these changes
Nov 29, 2019
jackysp
added
the
status/can-merge
|
/run-all-tests |
|
/run-all-tests |
|
@tennix merge failed. |
XiaTianliang
pushed a commit
to XiaTianliang/tidb
that referenced
this pull request
Dec 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: tennix ztennix@gmail.com
What problem does this PR solve?
After introducing automaxprocs in #13340, now tidb-server will always log a message
2019/11/28 14:18:22 maxprocs: Leaving GOMAXPROCS=4: CPU quota undefinedat startup which is annoying. This PR resolves this problem.What is changed and how it works?
According to this uber-go/automaxprocs#18 and uber-go/automaxprocs#19. We can disable this annoying log by importing
go.uber.org/automaxprocs/maxprocsand set the logger to a noplog.Check List
Tests
Now the annoying log disappears whenever runs tidb-server. And the
GOMAXPROCSis still set automatically.Code changes
None
Side effects
None
Related changes
Release note