Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the stop button #279

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

shameerariff
Copy link

Just added the stop button, probably it need testing as I do not have all the services installed in my env.

Add Stop button
stop button added
@codecov-io
Copy link

codecov-io commented Feb 13, 2021

Codecov Report

Merging #279 (fe3a7db) into develop (6222b72) will increase coverage by 1.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #279      +/-   ##
===========================================
+ Coverage    95.89%   96.90%   +1.01%     
===========================================
  Files            2        3       +1     
  Lines           73       97      +24     
===========================================
+ Hits            70       94      +24     
  Misses           3        3              
Impacted Files Coverage Δ
mopidy_musicbox_webclient/__init__.py 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6222b72...fe3a7db. Read the comment docs.

hard tab replaced by soft tabs
Hard tab replaced with softtab
Copy link
Author

@shameerariff shameerariff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hard tabs are replaced with soft tabs

Comment on lines +531 to +532
toast('Stopping current track...')
mopidy.playback.stop()

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The indentation on this line doesn't match the indentation in other functions on either side of this function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants