-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Nimib logging to stdout optional (-d:nimibQuiet
)
#242
Conversation
This option makes a lot of sense to add 👍 |
Another issue I have is that Nimib changes the current directory, which forces me to change it back myself (I use Prologue which searches for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me! (the only moment I paused is the echo left in blocks.nim, but I get that since we have a different type of output "prefix" we cannot reuse log and leaving the echo seems the most appropriate thing)
Thanks for this PR, it definitely makes sense to add the flag! This also will help the moment we want to improve logging in some way (but not doing that before someone has a clear use case or a need ;)). @HugoGranstrom not sure if you also want to review, otherwise for me this is good to merge! |
yes, there is a reason it changes directory (to access/create assets in the "build" directory, actually called homeDir, so that if I generate an image it is part of the assets that the static site will be able to see), but I can see other use cases not wanting that. I think it make sense to add a flag there (we are starting to have a bunch of them, at some point we might want to document them somewhere). For reference, the change of directory is here: Line 46 in 02b5253
|
...and I just realized that this feature ( |
A bit of documentation and I'm content with merging this 😁🚀 |
looking at |
Oh look at that :o Yes |
name changed & docs added! 👍 |
haha, forgot about that thanks again, looks good, will edit the title (so that when we make the changelog it will be already correct) and will merge this. |
-d:nimibNoLog
)-d:nimibQuiet
)
-d:nimibQuiet
)-d:nimibQuiet
)
I'd rather not have Nimib print to stdout all the time & fill up the terminal (esp. when compiling multiple documents!), and its better for users to have the option to disable logging.