Dockerised piccolo_admin #427
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
dantownsend
reviewed
Oct 18, 2024
Comment on lines
+4
to
+17
| # Set the working directory to /admin_ui | ||
| WORKDIR /admin_ui | ||
|
|
||
| # Copy the current directory contents into the container at /admin_ui | ||
| COPY admin_ui . | ||
|
|
||
| # Install any needed packages specified in package.json | ||
| RUN npm install --no-audit --no-fund | ||
|
|
||
| # Expose port 3000 | ||
| EXPOSE 3000 | ||
|
|
||
| # Run npm run dev when the container launches | ||
| CMD ["npm", "run", "dev"] |
There was a problem hiding this comment.
This solution is OK for development, but for production we don't need to install the npm dependencies etc. When we release piccolo_admin on PyPI, we bundle all of the front end assets.
So we just need a Python file which runs create_admin, but reads the database values from environment variables.
|
@dl-lim I think you should close this PR as we now have a dedicated repo for dockerized Piccolo Admin. Feel free to make changes to that repo. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basic copy of admin_ui in docker.
To add a standalone application in docker next, with .env to configure db connections.