Allow some inlinenodes to have child nodes #1162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaapio
force-pushed
the
nested-inline-nodes
branch
2 times, most recently
from
9ee0259
to
03c3e2e
Compare
jaapio
force-pushed
the
nested-inline-nodes
branch
2 times, most recently
from
c22ec47
to
e3716fd
Compare
jaapio
force-pushed
the
nested-inline-nodes
branch
from
e3716fd
to
87f3bfb
Compare
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
phpdoc-bot
added a commit
that referenced
this pull request
Oct 25, 2024
[1.x] Merge pull request #1162 from phpDocumentor/nested-inline-nodes
wouterj
reviewed
Nov 17, 2024
| use Doctrine\Deprecations\Deprecation; | ||
| use phpDocumentor\Guides\Nodes\InlineCompoundNode; | ||
|
|
||
| abstract class AbstractLinkInlineNode extends InlineCompoundNode implements LinkInlineNode |
There was a problem hiding this comment.
Just a fyi for next time: the change of parent class from InlineNode to InlineCompoundNode is a BC break for people that extend this base class in their code.
I've fixed this now in Symfony's alpha code, but it might be worth a notion in the release notes (and generally, I would advice to not introduce new deprecations in patch versions).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Markdown supports more nesting on nodes than RST does. To support this we needed to add support for compound nodes. We tried to be backward compatible for people building their own template. This layer will be removed in v2 and therfor we do trigger deprecations. See #1161
Fixes: #1160