Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecated use of string values for inline compound nodes #1161

Open
jaapio opened this issue Oct 25, 2024 · 0 comments
Open

Deprecated use of string values for inline compound nodes #1161

jaapio opened this issue Oct 25, 2024 · 0 comments
Labels
deprecation
Milestone
2.0.0

Comments

@jaapio
Copy link
Member

jaapio commented Oct 25, 2024

Feature request

Inline nodes extending InlineCompoundNode should not be accessed via getValue but getChildren should be used in the templates.

    {%- for child in node.children -%}
        {{- renderNode(child) -}}
    {%- endfor -%}

We will remove the backward compatibility layer in version 2.
@jaapio jaapio added this to the 2.0.0 milestone Oct 25, 2024
jaapio added a commit that referenced this issue Oct 25, 2024
@jaapio
Allow some inlinenodes to have child nodes
e0068c2 
Markdown supports more nesting on nodes than RST does. To support this
we needed to add support for compound nodes. We tried to be backward compatible
for people building their own template. This layer will be removed in v2 and
therfor we do trigger deprecations. See #1161

Fixes: #1160
@jaapio jaapio mentioned this issue Oct 25, 2024
Merged
jaapio added a commit that referenced this issue Oct 25, 2024
@jaapio
Markdown supports more nesting on nodes than RST does.
9ee0259 
To support this we needed to add support for compound nodes.
We tried to be backward compatible for people building their own template.
This layer will be removed in v2 and therfor we do trigger deprecations. See #1161

Fixes: #1160
jaapio added a commit that referenced this issue Oct 25, 2024
@jaapio
Markdown supports more nesting on nodes than RST does.
03c3e2e 
To support this we needed to add support for compound nodes.
We tried to be backward compatible for people building their own template.
This layer will be removed in v2 and therfor we do trigger deprecations. See #1161

Fixes: #1160
jaapio added a commit that referenced this issue Oct 25, 2024
@jaapio
Markdown supports more nesting on nodes than RST does.
c22ec47 
To support this we needed to add support for compound nodes.
We tried to be backward compatible for people building their own template.
This layer will be removed in v2 and therfor we do trigger deprecations. See #1161

Fixes: #1160
jaapio added a commit that referenced this issue Oct 25, 2024
@jaapio
Markdown supports more nesting on nodes than RST does.
e3716fd 
To support this we needed to add support for compound nodes.
We tried to be backward compatible for people building their own template.
This layer will be removed in v2 and therfor we do trigger deprecations. See #1161

Fixes: #1160
jaapio added a commit that referenced this issue Oct 25, 2024
@jaapio
Markdown supports more nesting on nodes than RST does.
87f3bfb 
To support this we needed to add support for compound nodes.
We tried to be backward compatible for people building their own template.
This layer will be removed in v2 and therfor we do trigger deprecations. See #1161

Fixes: #1160
phpdoc-bot pushed a commit that referenced this issue Oct 25, 2024
@jaapio
Markdown supports more nesting on nodes than RST does.
ca78413 
To support this we needed to add support for compound nodes.
We tried to be backward compatible for people building their own template.
This layer will be removed in v2 and therfor we do trigger deprecations. See #1161

Fixes: #1160
(cherry picked from commit 87f3bfb)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
deprecation
Projects
None yet
Milestone
2.0.0
Development

No branches or pull requests
1 participant
@jaapio