Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

_targets: use metaelf to embedd integrity metadata #1070

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

_targets: use metaelf to embedd integrity metadata #1070

wants to merge 1 commit into from

Conversation

gerard5
Copy link
Contributor

@gerard5 gerard5 commented May 8, 2024

metaelf is used to add integrity checksum to all apps and kernel only when phoenix-host-utils/metaelf is available (e.g. i.MXRT) or in custom projects.

JIRA: RTOS-296

2024-05-08-211243_2404x448_scrot

Description

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (refactoring, style fixes, git/CI config, submodule management, no code logic changes)

How Has This Been Tested?

  • Already covered by automatic testing.
  • New test added: (add PR link here).
  • Tested by hand on: imxrt1176-nil, ia32-generic.

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing linter checks and tests passed.
  • My changes generate no new compilation warnings for any of the targets.

Special treatment

  • This PR needs additional PRs to work (list the PRs, preferably in merge-order).
  • I will merge this PR by myself when appropriate.

@gerard5 gerard5 self-assigned this May 8, 2024
github-actions[bot]
github-actions bot reviewed May 8, 2024
View reviewed changes
_targets/build.common Outdated Show resolved Hide resolved
_targets: use metaelf to embedd integrity metadata
5fa6228 
`metaelf` is utilized to add integrity checksums to all apps and
the kernel if it is intended to load as an ELF file (using the
"kernel" command instead of "kernelimg" which is for binary image
of kernel) and only when `phoenix-host-utils/metaelf` is available
(e.g., i.MXRT) or in custom projects.

JIRA: RTOS-296
@gerard5 gerard5 marked this pull request as ready for review May 8, 2024 19:53
@github-actions GitHub Actions
Copy link

github-actions bot commented May 8, 2024

Unit Test Results

7 460 tests  ±0   6 745 ✅ ±0   37m 32s ⏱️ - 2m 27s
  420 suites ±0     715 💤 ±0 
    1 files   ±0       0 ❌ ±0 

Results for commit 5fa6228. ± Comparison against base commit 6f87c3f.

@gerard5 gerard5 requested review from anglov and agkaminski May 9, 2024 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@anglov anglov Awaiting requested review from anglov

@agkaminski agkaminski Awaiting requested review from agkaminski

At least 1 approving review is required to merge this pull request.

Assignees

@gerard5 gerard5

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@gerard5