feat: add protobuf/echo/ProtoMessageBuilder #416

richardapeters · 2023-09-14T10:25:34Z

No description provided.

github-actions · 2023-09-14T10:26:11Z

Dependency Review

✅ No vulnerabilities or license issues found.

Scanned Manifest Files

protobuf/echo/ProtoMessageBuilder.hpp

github-actions · 2023-09-14T10:29:33Z

🦙 MegaLinter status: ⚠️ WARNING

Descriptor	Linter	Files	Fixed	Errors	Elapsed time
✅ ACTION	actionlint	12		0	0.12s
✅ DOCKERFILE	hadolint	1		0	0.13s
✅ JSON	eslint-plugin-jsonc	10	0	0	6.83s
✅ JSON	prettier	10	0	0	0.76s
⚠️ MARKDOWN	markdownlint	7	1	11	1.64s
⚠️ MARKDOWN	markdown-link-check	7		1	49.83s
✅ MARKDOWN	markdown-table-formatter	7	1	0	0.48s
⚠️ SPELL	lychee	128		1	3.44s
⚠️ YAML	prettier	21	0	1	1.26s
✅ YAML	v8r	21		0	11.01s
✅ YAML	yamllint	21		0	0.47s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by

…ingStreamReader

protobuf/echo/ProtoMessageSender.cpp

protobuf/echo/ProtoMessageSender.hpp

protobuf/echo/test/TestProtoMessageSender.cpp

protobuf/echo/ProtoMessageSender.hpp

protobuf/echo/test/TestProtoMessageSender.cpp

…eReference::Get() const to avoid a warning

protobuf/echo/test/TestProtoMessageSender.cpp

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

…t a stream reader instead of a byte range

protobuf/echo/BufferingStreamReader.cpp

…treamWriter

infra/stream/test/TestBufferingStreamReader.cpp

infra/stream/test/TestBufferingStreamWriter.cpp

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

infra/stream/BufferingStreamReader.cpp

services/network/test_doubles/Certificates.cpp

sonarcloud · 2023-09-28T15:11:38Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

90.7% Coverage
1.5% Duplication

* feat: add order to pack upg supported targets * resolve review comments * refactor: resolved review comments * refactor: resolved review comments * style: fix build * refactor: resolved review comments * Update upgrade/pack_builder_instantiations/UpgradePackBuilderFacade.cpp Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * review comments resolved * build(deps): bump github/codeql-action from 2.21.6 to 2.21.7 (#417) Bumps [github/codeql-action](https://github.com/github/codeql-action) from 2.21.6 to 2.21.7. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@701f152...04daf01) --- updated-dependencies: - dependency-name: github/codeql-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * ci: consolidate configurations (#411) * ci: consolidate configurations * Change Package config into Host-Single-MinSizeRel, split Windows/MacOS workflows * Add Host-Single-Debug, use for MacOS ci * Disable sccache for Windows build * Consolidate Windows and MacOS builds * Explicitly enable tests * Apply suggestions from code review Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Use the correct configuration for the test preset * Presets now start with a lower case character * Presets now start with a lower case character * Presets now start with a lower case character * Update CMakePresets.json Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * .github/workflows/ci.yml: small improvements --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * build(deps): bump actions/checkout from 4.0.0 to 4.1.0 (#420) Bumps [actions/checkout](https://github.com/actions/checkout) from 4.0.0 to 4.1.0. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@3df4ab1...8ade135) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build(deps): bump actions/first-interaction from 1.1.1 to 1.2.0 (#421) Bumps [actions/first-interaction](https://github.com/actions/first-interaction) from 1.1.1 to 1.2.0. - [Release notes](https://github.com/actions/first-interaction/releases) - [Commits](actions/first-interaction@1d8459c...1dbfe1b) --- updated-dependencies: - dependency-name: actions/first-interaction dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build(deps): bump github/codeql-action from 2.21.7 to 2.21.9 (#422) Bumps [github/codeql-action](https://github.com/github/codeql-action) from 2.21.7 to 2.21.9. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@04daf01...ddccb87) --- updated-dependencies: - dependency-name: github/codeql-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore: switch static analysis to container (#423) * chore: update devcontainer * chore: switch static analysis to container * chore: use correct configurations * chore: remove workaround for missing symlinks When running into issues using mutation testing, please update your local devcontainer. * chore: use correct mutation-testing preset * chore: update CMakePresets.json * chore: update googletest * chore: use nproc for -j parameters * chore: revert version update in CMakePresets.json * deps: update mbedtls to 3.4.1 to silence warning See: Mbed-TLS/mbedtls#7098 * chore: fix compilation with clang-15 * chore: fix remaining issues * build(deps): bump oxsecurity/megalinter from 7.3.0 to 7.4.0 (#419) * build(deps): bump oxsecurity/megalinter from 7.3.0 to 7.4.0 Bumps [oxsecurity/megalinter](https://github.com/oxsecurity/megalinter) from 7.3.0 to 7.4.0. - [Release notes](https://github.com/oxsecurity/megalinter/releases) - [Changelog](https://github.com/oxsecurity/megalinter/blob/main/CHANGELOG.md) - [Commits](oxsecurity/megalinter@fda6ac3...a87b287) --- updated-dependencies: - dependency-name: oxsecurity/megalinter dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * chore: fix linter findings --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Ron <45816308+rjaegers@users.noreply.github.com> * feat: add protobuf/echo/ProtoMessageBuilder (#416) * feat: add protobuf/echo/ProtoMessageBuilder * ProtoCEchoPlugin: Fix superfluous typename * protobuf/echoProtoMessageBuilder: Parse a lot of different types * protobuf/echoProtoMessageBuilder: Parse enums, strings, extract BuferingStreamReader * Resolve code warnings, increase coverage * protobuf/echo: Add BufferingStreamWriter * protobuf/echo: Add half of ProtoMessageSender * protobuf/echo/ProtoMessageSender: Serialize lots of types * protobuf/echo/ProtoMessageSender: Fix missing template keyword * protobuf/echo/ProtoMessageSender: Serialize lots of types * protobuf/protoc_echo_plugin/ProtoCEchoPlugin: Modify result of MessageReference::Get() const to avoid a warning * Apply suggestions from code review Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * protobuf/echo/BufferingStreamReader: Make BufferingStreamReader accept a stream reader instead of a byte range * protobuf/echo/BufferingStreamReader: Remove useless comment * Resolve Sonar warnings * Resolve Sonar warnings * Move BufferingSteamReader and BufferingStreamWriter to infra/stream * infra/stream/test: Add tests for BufferingStreamReader and BufferingStreamWriter * Apply suggestions from code review Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Resolve Sonar warnings * Resolve Sonar warnings * Resolve Sonar warnings * Reduce duplication * Update services/network/test_doubles/Certificates.cpp --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Ron <45816308+rjaegers@users.noreply.github.com> * build(deps): bump google-github-actions/release-please-action from 3.7.11 to 3.7.12 (#426) build(deps): bump google-github-actions/release-please-action Bumps [google-github-actions/release-please-action](https://github.com/google-github-actions/release-please-action) from 3.7.11 to 3.7.12. - [Release notes](https://github.com/google-github-actions/release-please-action/releases) - [Changelog](https://github.com/google-github-actions/release-please-action/blob/main/CHANGELOG.md) - [Commits](google-github-actions/release-please-action@ca6063f...4c5670f) --- updated-dependencies: - dependency-name: google-github-actions/release-please-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build(deps): bump oss-fuzz-base/base-builder from `5e1404d` to `6c61e46` in /.clusterfuzzlite (#427) build(deps): bump oss-fuzz-base/base-builder in /.clusterfuzzlite Bumps oss-fuzz-base/base-builder from `5e1404d` to `6c61e46`. --- updated-dependencies: - dependency-name: oss-fuzz-base/base-builder dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build: add emil_install to emil_build_for.cmake which only installs the target if it is part of the All target (#425) (cherry picked from commit b669983) * build(deps): bump seanmiddleditch/gha-setup-ninja from 3 to 4 (#430) Bumps [seanmiddleditch/gha-setup-ninja](https://github.com/seanmiddleditch/gha-setup-ninja) from 3 to 4. - [Release notes](https://github.com/seanmiddleditch/gha-setup-ninja/releases) - [Commits](seanmiddleditch/gha-setup-ninja@16b9408...8b29707) --- updated-dependencies: - dependency-name: seanmiddleditch/gha-setup-ninja dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build(deps): bump ossf/scorecard-action from 2.2.0 to 2.3.0 (#432) Bumps [ossf/scorecard-action](https://github.com/ossf/scorecard-action) from 2.2.0 to 2.3.0. - [Release notes](https://github.com/ossf/scorecard-action/releases) - [Changelog](https://github.com/ossf/scorecard-action/blob/main/RELEASE.md) - [Commits](ossf/scorecard-action@08b4669...483ef80) --- updated-dependencies: - dependency-name: ossf/scorecard-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build(deps): bump github/codeql-action from 2.21.9 to 2.22.1 (#433) Bumps [github/codeql-action](https://github.com/github/codeql-action) from 2.21.9 to 2.22.1. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@ddccb87...fdcae64) --- updated-dependencies: - dependency-name: github/codeql-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore: make services/util/MessageCommunicationSecured compliant with MbedTLS version 2 (#434) * chore: make services/util/MessageCommunicationSecured compliant with MbedTLS version 2 * services/util/MessageCommunicationSecured: Include mbedtls/version.h * build(deps): bump github/codeql-action from 2.22.1 to 2.22.3 (#437) Bumps [github/codeql-action](https://github.com/github/codeql-action) from 2.22.1 to 2.22.3. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@fdcae64...0116bc2) --- updated-dependencies: - dependency-name: github/codeql-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build(deps): bump actions/checkout from 4.1.0 to 4.1.1 (#438) Bumps [actions/checkout](https://github.com/actions/checkout) from 4.1.0 to 4.1.1. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@8ade135...b4ffde6) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * feat: removed Dac.hpp (#439) * feat: added SerialCommunicationLoopback (#440) * feat: added SerialCommunicationLoopback * chore: replaced ClockFixture with EventDispatcherFixture * chore: made SerialCommunicationLoopback compatible with <= GCC9 * chore: fixed comments * chore: correct comparing byte ranges for SerialCommunicationLoopbackTest * chore: fix coverage and macos build --------- Co-authored-by: Daan Timmer <daan.timmer@gmail.com> * fix: added workaround mbedtls and clang-cl incomatibility (#441) * fix: added workaround by replacing CMAKE_C_COMPILER_ID with CMAKE_C_SIMULATE_ID when configuring mbedtls * chore: reworked comment and removed references to xwin * build(deps): bump Namchee/conventional-pr from 0.14.0 to 0.14.1 (#443) Bumps [Namchee/conventional-pr](https://github.com/namchee/conventional-pr) from 0.14.0 to 0.14.1. - [Release notes](https://github.com/namchee/conventional-pr/releases) - [Commits](Namchee/conventional-pr@5d1221f...cc86d48) --- updated-dependencies: - dependency-name: Namchee/conventional-pr dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build(deps): bump ossf/scorecard-action from 2.3.0 to 2.3.1 (#444) Bumps [ossf/scorecard-action](https://github.com/ossf/scorecard-action) from 2.3.0 to 2.3.1. - [Release notes](https://github.com/ossf/scorecard-action/releases) - [Changelog](https://github.com/ossf/scorecard-action/blob/main/RELEASE.md) - [Commits](ossf/scorecard-action@483ef80...0864cf1) --- updated-dependencies: - dependency-name: ossf/scorecard-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build(deps): bump github/codeql-action from 2.22.3 to 2.22.4 (#442) Bumps [github/codeql-action](https://github.com/github/codeql-action) from 2.22.3 to 2.22.4. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@0116bc2...49abf0b) --- updated-dependencies: - dependency-name: github/codeql-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build: only build and install protobuf echo compilers when EMIL_BUILD_ECHO_COMPILERS is set (#445) * build: only build and install protobuf echo compilers when EMIL_BUILD_ECHO_COMPILERS is set * protobuf/protoc_echo_plugin*/CMakeLists: Fix emil_build_for statement * Install export file, but only whene EMIL_BUILD_ECHO_COMPILERS * build(deps): bump oxsecurity/megalinter from 7.4.0 to 7.5.0 (#446) Bumps [oxsecurity/megalinter](https://github.com/oxsecurity/megalinter) from 7.4.0 to 7.5.0. - [Release notes](https://github.com/oxsecurity/megalinter/releases) - [Changelog](https://github.com/oxsecurity/megalinter/blob/main/CHANGELOG.md) - [Commits](oxsecurity/megalinter@a87b287...b48455a) --- updated-dependencies: - dependency-name: oxsecurity/megalinter dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build(deps): bump github/codeql-action from 2.22.4 to 2.22.5 (#447) Bumps [github/codeql-action](https://github.com/github/codeql-action) from 2.22.4 to 2.22.5. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@49abf0b...74483a3) --- updated-dependencies: - dependency-name: github/codeql-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build(deps): bump Namchee/conventional-pr from 0.14.1 to 0.15.1 (#448) Bumps [Namchee/conventional-pr](https://github.com/namchee/conventional-pr) from 0.14.1 to 0.15.1. - [Release notes](https://github.com/namchee/conventional-pr/releases) - [Commits](Namchee/conventional-pr@cc86d48...93f5107) --- updated-dependencies: - dependency-name: Namchee/conventional-pr dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build(deps): bump carlosperate/arm-none-eabi-gcc-action from 1.7.1 to 1.8.0 (#449) build(deps): bump carlosperate/arm-none-eabi-gcc-action Bumps [carlosperate/arm-none-eabi-gcc-action](https://github.com/carlosperate/arm-none-eabi-gcc-action) from 1.7.1 to 1.8.0. - [Release notes](https://github.com/carlosperate/arm-none-eabi-gcc-action/releases) - [Changelog](https://github.com/carlosperate/arm-none-eabi-gcc-action/blob/main/CHANGELOG.md) - [Commits](carlosperate/arm-none-eabi-gcc-action@6a221d7...e9cd61b) --- updated-dependencies: - dependency-name: carlosperate/arm-none-eabi-gcc-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix review comments * Update upgrade/pack_builder_instantiations/UpgradePackBuilderFacade.cpp Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Update upgrade/pack_builder_instantiations/UpgradePackBuilderFacade.cpp Co-authored-by: Richard Peters <richard.peters@philips.com> * refactor: fix review comments --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Richard Peters <richard.peters@philips.com> Co-authored-by: Ron <45816308+rjaegers@users.noreply.github.com> Co-authored-by: Daan Timmer <8293597+daantimmer@users.noreply.github.com> Co-authored-by: Daan Timmer <daan.timmer@gmail.com>

feat: add protobuf/echo/ProtoMessageBuilder

caf1d6d

richardapeters requested a review from a team as a code owner September 14, 2023 10:25

github-actions bot reviewed Sep 14, 2023

View reviewed changes

protobuf/echo/ProtoMessageBuilder.hpp Outdated Show resolved Hide resolved

richardapeters and others added 6 commits September 14, 2023 12:50

ProtoCEchoPlugin: Fix superfluous typename

3659327

protobuf/echoProtoMessageBuilder: Parse a lot of different types

4850e98

protobuf/echoProtoMessageBuilder: Parse enums, strings, extract Bufer…

7ad854d

…ingStreamReader

Resolve code warnings, increase coverage

7af4bfd

protobuf/echo: Add BufferingStreamWriter

7143d43

protobuf/echo: Add half of ProtoMessageSender

9f6c3ad

github-actions bot reviewed Sep 18, 2023

View reviewed changes

protobuf/echo/ProtoMessageSender: Serialize lots of types

5c9f178

github-actions bot reviewed Sep 21, 2023

View reviewed changes

protobuf/echo/ProtoMessageSender.hpp Outdated Show resolved Hide resolved

protobuf/echo/test/TestProtoMessageSender.cpp Outdated Show resolved Hide resolved

protobuf/echo/test/TestProtoMessageSender.cpp Outdated Show resolved Hide resolved

richardapeters added 2 commits September 21, 2023 11:47

protobuf/echo/ProtoMessageSender: Fix missing template keyword

2b44b0f

protobuf/echo/ProtoMessageSender: Serialize lots of types

50f67fa

github-actions bot reviewed Sep 21, 2023

View reviewed changes

protobuf/echo/test/TestProtoMessageSender.cpp Outdated Show resolved Hide resolved

protobuf/protoc_echo_plugin/ProtoCEchoPlugin: Modify result of Messag…

f3b4b37

…eReference::Get() const to avoid a warning

richardapeters commented Sep 21, 2023

View reviewed changes

protobuf/echo/test/TestProtoMessageSender.cpp Outdated Show resolved Hide resolved

richardapeters and others added 2 commits September 21, 2023 14:04

Apply suggestions from code review

7ff3ff4

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

protobuf/echo/BufferingStreamReader: Make BufferingStreamReader accep…

4d866f2

…t a stream reader instead of a byte range

github-actions bot reviewed Sep 22, 2023

View reviewed changes

protobuf/echo/BufferingStreamReader.cpp Outdated Show resolved Hide resolved

richardapeters and others added 5 commits September 22, 2023 10:06

protobuf/echo/BufferingStreamReader: Remove useless comment

e216526

Resolve Sonar warnings

88b5d8a

Resolve Sonar warnings

67182ec

Move BufferingSteamReader and BufferingStreamWriter to infra/stream

62b5a07

infra/stream/test: Add tests for BufferingStreamReader and BufferingS…

d6cf3e4

…treamWriter

github-actions bot reviewed Sep 26, 2023

View reviewed changes

infra/stream/test/TestBufferingStreamReader.cpp Outdated Show resolved Hide resolved

infra/stream/test/TestBufferingStreamWriter.cpp Outdated Show resolved Hide resolved

richardapeters and others added 2 commits September 26, 2023 14:26

Apply suggestions from code review

cf83d99

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Resolve Sonar warnings

7ec732d

richardapeters and others added 2 commits September 27, 2023 16:23

Resolve Sonar warnings

3625a48

Resolve Sonar warnings

a0b2451

rjaegers reviewed Sep 28, 2023

View reviewed changes

infra/stream/BufferingStreamReader.cpp Outdated Show resolved Hide resolved

rjaegers reviewed Sep 28, 2023

View reviewed changes

infra/stream/BufferingStreamReader.cpp Outdated Show resolved Hide resolved

Reduce duplication

2b8cfea

rjaegers reviewed Sep 28, 2023

View reviewed changes

services/network/test_doubles/Certificates.cpp Outdated Show resolved Hide resolved

rjaegers approved these changes Sep 28, 2023

View reviewed changes

richardapeters and others added 2 commits September 28, 2023 10:14

Update services/network/test_doubles/Certificates.cpp

84d2f94

Merge branch 'main' into feature/proto_message_builder

9cc8c23

richardapeters added this pull request to the merge queue Sep 28, 2023

Merged via the queue into main with commit f5260dd Sep 28, 2023
28 checks passed

richardapeters deleted the feature/proto_message_builder branch September 28, 2023 16:55

rjaegers mentioned this pull request Sep 28, 2023

chore(main): release 5.0.0 #326

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add protobuf/echo/ProtoMessageBuilder #416

feat: add protobuf/echo/ProtoMessageBuilder #416

richardapeters commented Sep 14, 2023

github-actions bot commented Sep 14, 2023 •

edited

Loading

github-actions bot commented Sep 14, 2023 •

edited

Loading

sonarcloud bot commented Sep 28, 2023 •

edited

Loading

feat: add protobuf/echo/ProtoMessageBuilder #416

feat: add protobuf/echo/ProtoMessageBuilder #416

Conversation

richardapeters commented Sep 14, 2023

github-actions bot commented Sep 14, 2023 • edited Loading

Dependency Review

Scanned Manifest Files

github-actions bot commented Sep 14, 2023 • edited Loading

🦙 MegaLinter status: ⚠️ WARNING

sonarcloud bot commented Sep 28, 2023 • edited Loading

github-actions bot commented Sep 14, 2023 •

edited

Loading

github-actions bot commented Sep 14, 2023 •

edited

Loading

sonarcloud bot commented Sep 28, 2023 •

edited

Loading