-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement bulk key fetching and deleting for large queue #44
base: master
Are you sure you want to change the base?
Conversation
7b3b989
to
d3e5936
Compare
d3e5936
to
21b33e1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left several comments. PTAL.
Client: client, | ||
Backoff: backoffConfig, | ||
ChunkSizeInGet: 1000, | ||
ChunkSizeInDelete: 1000, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you mind adding tests for chunked deletion (large queue)??
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a test for chunked deletion.
f2b8503
Co-authored-by: Shingo Omura <everpeace@gmail.com>
e379032
to
f2b8503
Compare
We want to reduce redis load by delete-queue command when the queue has a large number of tasks.
*a large number is about 10^6
I implemented following improvements:
fixes #28