Use method, not Moose interals in tests #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We used to use the internals of how blessed objects work, by doing
`$obj->{foo}` instead of `$obj->foo`. This poses several issues:
1. We can't easily refactor code, because we can rename the attributes
but when accessing them in tests it fails.
2. If Moose for $reasons decide to change their API we are also doing
things wrong.
So fix it :)
Signed-off-by: Wesley Schwengle <waterkip@cpan.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We used to use the internals of how blessed objects work, by doing
$obj->{foo}instead of$obj->foo. This poses several issues:We can't easily refactor code, because we can rename the attributes but when accessing them in tests it fails.
If Moose for $reasons decide to change their API we are also doing things wrong.
So fix it :)