Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't mention key usage unless we have both signing and encryption #206

Merged
merged 2 commits into from
Apr 18, 2024
Merged

Don't mention key usage unless we have both signing and encryption #206

merged 2 commits into from
Apr 18, 2024

Conversation

waterkip
Copy link
Collaborator

@waterkip waterkip commented Apr 9, 2024

Closes: #205

@waterkip
Don't mention key usage unless we have both signing and encryption
3c87e51 
Closes: perl-net-saml2#205

Signed-off-by: Wesley Schwengle <waterkip@cpan.org>
@waterkip
Remove code for old builders
70adeb6 
Signed-off-by: Wesley Schwengle <waterkip@cpan.org>
timlegge
timlegge approved these changes Apr 18, 2024
View reviewed changes
Copy link
Contributor

@timlegge timlegge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Figured out my issue I was using an installed version of the module

LGTM

lib/Net/SAML2/SP.pm Show resolved Hide resolved
@waterkip waterkip merged commit 78fc289 into perl-net-saml2:master Apr 18, 2024
4 checks passed
@waterkip waterkip deleted the GH-205-signing_key branch April 18, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timlegge timlegge timlegge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Key usage in Net::SAML2 is always signing
2 participants
@waterkip @timlegge