Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small improvement to the transition animation of the tabs selection in some places. #132

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

MTG2000
Copy link
Collaborator

@MTG2000 MTG2000 commented Aug 25, 2022

This is just a small PR where I used an improved way to transition between the currently active tab item.
You can view it in:

  • Edit profile selected tab on web
  • Edit profile selected tab on mobile
  • Write story edit/preview switch

The change is not very huge, but personally I feel that this way it looks more like native-like, and simply cooler! 😎
Check it out & let me know if you like it this way better, or if you prefer the original one.

@netlify
Copy link

netlify bot commented Aug 25, 2022

Deploy Preview for makers-bolt-fun-preview ready!

Name Link
🔨 Latest commit 286a614
🔍 Latest deploy log https://app.netlify.com/sites/makers-bolt-fun-preview/deploys/6307928966165c00091bd36f
😎 Deploy Preview https://deploy-preview-132--makers-bolt-fun-preview.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Aug 25, 2022

Deploy Preview for makers-bolt-fun-stories ready!

Name Link
🔨 Latest commit 286a614
🔍 Latest deploy log https://app.netlify.com/sites/makers-bolt-fun-stories/deploys/63079289813ccb000809e0f9
😎 Deploy Preview https://deploy-preview-132--makers-bolt-fun-stories.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@johnsBeharry
Copy link
Member

@barefoot-88 let me know what you think. I'm fine with the update the only feedback I'd give us the lack of consistency with other similar buttons though out the site. Do we launch with just one section having this effect so the code is live, or have it done consistently through out the platform. As you can imagine I'd lean on consistency throughout, but you'll have to do the QA on this so I'll leave that up to you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants