Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make lib more "modern" #4

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

PapiOphidian
Copy link

This PR changes a bit, but nothing breaking as far as I can tell.

Change log:

  • Update dependencies to be more "modern".
  • include package-lock.json.
  • Add JSDoc comments.
  • Tell my editor to shut up about some logic.
  • Add TypeScript as a dev dep so that it may generate .d.ts files automatically. (basically necessary for typescript users)
  • Use some modern syntax such as for of verses for let and const/let initializers instead of var which is discouraged.
  • Move the regex in WAV to the global scope to avoid recompilation of the regex for each function call.

If this ends up breaking compatibility with the target node version/web browsers then I'll see about remedying that.

How babel works now is that it must use the @babel/plugin-env node module in tandem with a browserlist to target specific browsers which I have included the oldest not dead browsers.

How gulp works now is that instead of telling gulp which tasks need to complete before other tasks in an Array in the task call, gulp wants you to use another function which accepts an Array of tasks that run sequentially. This cannot be spread across multiple files as far as I can tell without importing it when they export their own functions which was pretty useless in this case, so I have merged the files and the default task is now the browserify task.

The prepublish script now also generates .d.ts files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant