Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Edelman response function #9

Merged
merged 3 commits into from
Aug 5, 2024
Merged

Add Edelman response function #9

merged 3 commits into from
Aug 5, 2024

Conversation

martinvonk
Copy link
Contributor

@martinvonk martinvonk commented Aug 5, 2024

Edelman needs to be removed in future version of pastas and added to the plugins library. See Pastas issue #475

The exponential_parameters function is useful for extracting the corresponding Pastas parameters for physically realistic systems, just as kraijenhoff_parameters.

Copy link
Member

@dbrakenhoff dbrakenhoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests seem quite generic, we could just test all response functions this way instead of writing tests for each?

@martinvonk
Copy link
Contributor Author

The tests seem quite generic, we could just test all response functions this way instead of writing tests for each?

Agree, made an issue #10

@martinvonk martinvonk merged commit 646df69 into dev Aug 5, 2024
14 checks passed
@martinvonk martinvonk deleted the rfunc-edelman-linres branch August 9, 2024 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants