Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove debug check no longer needed for control fields #933

Merged
merged 2 commits into from
Aug 29, 2023

Conversation

Yurlungur
Copy link
Collaborator

@Yurlungur Yurlungur commented Aug 29, 2023

PR Summary

What it says on the tin. Sparse control fields mean mean that a sparse variable may not be allocated when it receives boundary data, if it's controlled by another variable. We just missed the removal of this debug check when that feature was made robust.

PR Checklist

  • Code passes cpplint
  • New features are documented.
  • Adds a test for any bugs fixed. Adds tests for new features.
  • Code is formatted
  • Changes are summarized in CHANGELOG.md
  • CI has been triggered on Darwin for performance regression tests.
  • Docs build
  • (@lanl.gov employees) Update copyright on changed files

@Yurlungur Yurlungur added the bug Something isn't working label Aug 29, 2023
@Yurlungur Yurlungur self-assigned this Aug 29, 2023
Copy link
Collaborator

@jdolence jdolence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Let's get this merged ASAP.

Copy link
Collaborator

@lroberts36 lroberts36 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for catching that!

@Yurlungur Yurlungur merged commit 11c53d1 into develop Aug 29, 2023
49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants