-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Add boundary comm inner loop specializations for performance and allow setting vector length #1175
Open
lroberts36
wants to merge
9
commits into
develop
Choose a base branch
from
lroberts36/boundary-comms-perforfmance-upgrades
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
WIP: Add boundary comm inner loop specializations for performance and allow setting vector length #1175
lroberts36
wants to merge
9
commits into
develop
from
lroberts36/boundary-comms-perforfmance-upgrades
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lroberts36
requested review from
Yurlungur,
pgrete,
pdmullen,
bprather and
jdolence
September 12, 2024 16:46
Yurlungur
approved these changes
Sep 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! This is a good change that should hopefully help with performance.
pdmullen
approved these changes
Sep 13, 2024
…6/boundary-comms-perforfmance-upgrades
lroberts36
changed the title
Add boundary comm inner loop specializations for performance and allow setting vector length
WIP: Add boundary comm inner loop specializations for performance and allow setting vector length
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
This PR adds various inner loop specializations to avoid calling reductions, coordinate transformations, and masks in the inner boundary buffer setting loops where possible. I found this made a little bit of a difference for the multigrid communication, not sure that it really matters elsewhere.
It also exposes a flag
parthenon/mesh/comm_vector_length
which sets the vector length of the outer team policy. We have always used the Kokkos default value here (which is one). I am not sure if changing this value has any impact, but I at least wanted to be able to play around with it.As an aside, once #1142 is in, we may want to switch these loops to
par_for
s instead of raw Kokkos loops.PR Checklist