-
-
Notifications
You must be signed in to change notification settings - Fork 871
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Fix jazzy undocumented symbols #1820
Conversation
Thanks for opening this pull request!
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1820 +/- ##
===========================================
+ Coverage 64.24% 82.79% +18.55%
===========================================
Files 201 282 +81
Lines 23233 30726 +7493
===========================================
+ Hits 14926 25441 +10515
+ Misses 8307 5285 -3022 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are the tests failing
@mtrezza For some reason functions that return BFTask can't be called in swift after this change.
|
I also wanted to say that there a quite a few changes in code so not sure if that can be considered "only " a docs PR? |
@mtrezza I found a cleaner way to do this, simple refactoring. I think the build is broken too |
The build worked in the PR last week, so I assume it's this PR that breaks it? |
All my PR’s have flaky test introduced, simulators we use aren’t available anymore in certain version of Xcode, I don’t know if it’s a github action issue |
Not sure I understand; the CI currently passes, see for example https://github.com/parse-community/Parse-SDK-iOS-OSX/actions/runs/11758150963. All jobs passed at first run, but to be sure, I've restarted the CI for another run to see if there is any flakiness. I've restarted the CI here too, so we can compare the errors between the two runs. |
Turns out the CI is also flaky in that other PR. So I'll just rerun the CI here until hopefully all pass. |
@dplewis I couldn't get the CI to pass, even after re-running the failed tests multiple times. What should we do here? |
I closed this because it introduces a breaking change when using this SDK in a swift environment. Can you do a release PR? The Xcode 16 support got added. If that PR has flaky test then I don’t know what to do but as least we can investigate |
Are the changes in 0be6870 necessary to use the SDK in Xcode 16? I assumed it only added the Xcode 16 tests to the CI and the gemfile dependency upgrades were done additionally but not required for Xcode 16. Hence this wasn't merged as feature release. |
Just a suggestion if you want to update the change log then a release would be nice. A patch release would work as no functionality has changed. |
I think you are right, that should have been merged as |
New Pull Request Checklist
Issue Description
There are a lot of errors when generating docs that prevents symbols from being documented.
https://github.com/parse-community/Parse-SDK-iOS-OSX/actions/runs/11596782336/job/32288646411
Before
After
Approach
@import Bolts
to.m
and add@class
to.h
dataAvailable
from catetoriesTODOs before merging