-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Place scheduled on sectionQuery, use startDate from schedule. #249
base: master
Are you sure you want to change the base?
Conversation
@@ -69,6 +69,7 @@ module.exports = async ({ | |||
else: '$expires', | |||
}, | |||
}, | |||
scheduled: '$startDate', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's this intended to be used for?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For what purpose? Section query intentionally uses published date to correct certain schedule start dates... in that example, that start date is actually wrong... you shouldn't be able to start content before it's actually published. Nothing in the interface prevents this, per se, hence why section query enforces this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't agree with the idea of putting dates prior to the publish date anywhere.
@Shinsina we're going to hold on these changes for now, pending some other options |
Ref: #247