Re-enable Wycheproof tests

paragonie · Apr 30, 2024 · 9f273c4 · 9f273c4
1 parent 84b5dfa
commit 9f273c4
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 5 deletions.
diff --git a/composer.json b/composer.json
@@ -36,7 +36,7 @@
         "php": "^7.1||^8.0",
         "paragonie/sodium_compat": "^1|^2",
         "ext-gmp": "*",
-        "genkgo/php-asn1": "^2"
+        "genkgo/php-asn1": "^2.7"
     },
     "require-dev": {
         "phpunit/phpunit": "^6|^7|^8|^9",

diff --git a/tests/wycheproof/EcdsaTest.php b/tests/wycheproof/EcdsaTest.php
@@ -74,7 +74,7 @@ private function readSpecificSet(string $curveName, string $hasherName): array
     public function getEcdsaTestVectors(): array
     {
         $fixtures = json_decode($this->importFile("import/wycheproof/testvectors/ecdsa_test.json"), true);
-        $disabledFlags = ["MissingZero", "BER"];
+        $disabledFlags = ["MissingZero"];
         return $this->filterSet($fixtures, $this->getCurvesList(), $disabledFlags);
     }
 
@@ -222,9 +222,6 @@ protected function doTest(GeneratorPoint $generator, PublicKey $publicKey, Hashe
         $verified = false;
         $error = false;
         $signer = new Signer($generator->getAdapter());
-        if (in_array('BER', $flags)) {
-            $this->markTestSkipped('BER testing is temporarily disabled');
-        }
 
         try {
             $sigSer = new DerSignatureSerializer();