Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(client_metadata): add empty string and null checks to client_name test #1238

Closed
wants to merge 1 commit into from
Closed

test(client_metadata): add empty string and null checks to client_name test #1238

wants to merge 1 commit into from

Conversation

KalleV
Copy link
Contributor

@KalleV KalleV commented Dec 3, 2023

Add assertions to test the empty string and null value checks for the "client_name" metadata. For example:

Error: InvalidClientMetadata received invalid_client_metadata client_name must be a non-empty string if provided

@panva
Copy link
Owner

panva commented Dec 3, 2023

IIRC these assertions are already part of mustBeString

@KalleV
Copy link
Contributor Author

KalleV commented Dec 3, 2023

IIRC these assertions are already part of mustBeString

Ah, okay. I see that now. Thanks, I'll close this one.

@KalleV KalleV closed this Dec 3, 2023
@KalleV KalleV deleted the config/client_metadata_test branch December 3, 2023 16:53
@github-actions github-actions bot locked and limited conversation to collaborators Mar 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KalleV @panva