implement a readonly and a disabled validator #797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I should look how this behaves for |
azmeuk
force-pushed
the
issue-792-readonly-disabled-fields
branch
from
6aa6fd9
to
40e39f3
Compare
azmeuk
force-pushed
the
issue-792-readonly-disabled-fields
branch
from
40e39f3
to
df64872
Compare
ThiefMaster
reviewed
Sep 29, 2023
src/wtforms/validators.py
Outdated
Comment on lines
703
to
704
| Validation fails if the form data is different than the | ||
| field object data, or if unset, from the field default data. |
There was a problem hiding this comment.
Fixed. Now this is Validation fails if the form data has any value.
azmeuk
force-pushed
the
issue-792-readonly-disabled-fields
branch
from
df64872
to
2e8d970
Compare
azmeuk
force-pushed
the
issue-792-readonly-disabled-fields
branch
from
2e8d970
to
5ae63d8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #792
This adds two validators readonly and disabled.
The validators adds the corresponding flags on the widgets on which this is authorized, according to MDN.
The
readonlyvalidator raises aValidationErrorif the formdata is different than the object data for a given form. Thedisabledvalidator raises aValidationErrorif the formdata is different thanNone.Readonly fields are sent by the browser, and disabled ones are not. Either ways those validators prevents the user from cheating and submitting different values that the ones they have been presented.
If someone wants a readonly field but does not want to enforce the immutability, they still can use render_kw.