Improve logging #20
Open
Improve logging #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Victor Toni <victor.toni@gmail.com>
* To make reformatting reproducible `make reformat` was used. Signed-off-by: Victor Toni <victor.toni@gmail.com>
Code provied by Stefan Heck. Signed-off-by: Victor Toni <victor.toni@gmail.com>
…g doesn't know about them). Signed-off-by: Victor Toni <victor.toni@gmail.com>
Signed-off-by: Victor Toni <victor.toni@gmail.com>
Signed-off-by: Victor Toni <victor.toni@gmail.com>
|
This PR depends on #19. Therefore in current state cannot be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When logging to stderr timestamps are added to the output making debugging a lot easiser.
Additionally the short circuit log level evaluation avoid unnecessary function calls if these log calls wouldn't be shown because of the log level.
This feature might be especially useful for embedded devices.
This PR is based on PR #19.