Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow overriding props of components #202

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

gylxan
Copy link

@gylxan gylxan commented Jan 9, 2024

Allow overriding props of components.
Also made it possible to set the type for the CommandInput.

Fix #201

Copy link

vercel bot commented Jan 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cmdk-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 9, 2024 0:25am

@gylxan
Copy link
Author

gylxan commented Jan 9, 2024

@pacocoursey Would you be so kind to approve the workflow to run the tests?

@McTom234
Copy link

@gylxan I think this needs to be rebased...

@tonyfarney
Copy link

This modification would allow us to workaround accessibility issues the library has. For example: #179

Please merge the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: allow overwriting props
3 participants