Refactoring: Split code into smaller readable chunks

pH-7 · Aug 20, 2023 · b7e95d2 · b7e95d2
1 parent bf04dc7
commit b7e95d2
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 13 deletions.
diff --git a/src/Dal/FoodItemDal.php b/src/Dal/FoodItemDal.php
@@ -49,7 +49,7 @@ function (object $itemBean): array {
             }, $itemsBean);
     }
 
-    public static function createDefaultItem(ItemEntity $itemEntity): int|string
+    public static function insertDefaultItem(ItemEntity $itemEntity): int|string
     {
         $itemBan = R::dispense(self::TABLE_NAME);
 

diff --git a/src/Service/FoodItem.php b/src/Service/FoodItem.php
@@ -42,18 +42,7 @@ public function retrieveAll(): array
         $items = FoodItemDal::getAll();
 
         if (count($items) === 0) {
-            // if no items have been added yet, create the first one
-            $itemUuid = Uuid::uuid4()->toString();
-            $itemEntity = new ItemEntity();
-
-            // chaining each method with the arrow ->
-            $itemEntity
-                ->setItemUuid($itemUuid)
-                ->setName('Burrito Cheese with French Fries')
-                ->setPrice(19.99)
-                ->setAvailable(true);
-
-            FoodItemDal::createDefaultItem($itemEntity);
+            $this->createDefaultItem();
 
             // then, get again all items
             // to retrieve the new one that just got added
@@ -62,4 +51,25 @@ public function retrieveAll(): array
 
         return $items;
     }
+
+    private function createDefaultItem(): void
+    {
+        // default item values
+        $defaultPrice = 19.99;
+        $isEnabled = true;
+
+
+        // if no items have been added yet, create the first one
+        $itemUuid = Uuid::uuid4()->toString();
+        $itemEntity = new ItemEntity();
+
+        // chaining each method with the arrow ->
+        $itemEntity
+            ->setItemUuid($itemUuid)
+            ->setName('Burrito Cheese with French Fries')
+            ->setPrice($defaultPrice)
+            ->setAvailable($isEnabled);
+
+        FoodItemDal::insertDefaultItem($itemEntity);
+    }
 }