Fix: Broken list items by comma #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we had track, album or playlist items with a comma the regex used for creating table removed necessary parts of the string. This commit fixes this issue by using osascript's `-s` flag with a value `s` which returns a recompilable source form. The new type of return then can be processed into a table with `loadstring`.
p5quared
approved these changes
Jul 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
When we had track, album, or playlist items with a comma, the regex used for creating the table removed necessary parts of the string. This commit fixes this issue by using osascript's
-sflag with a valueswhich returns a recompilable source form (for more details seeman osascript). The new return value (it'll be in this format:'{"song1", "song2", "song3"}') can then be converted into a table withloadstring.Example of the issue and fix: