Fix reading and writing of project files #348
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d by format definition
…ilter Previously, the VCP output format could never be selected, because the save function checked for the filter name "VidCutter Project (*.vcp)", while the save dialog returned "VidCutter Project" (because it has QFileDialog.HideNameFilterDetails set on it).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses multiple problems with project files (see #272 and in particular #272 (comment)):
One feature goes a bit beyond bugfixing, but should probably be useful:
This also allows reading the "broken" project files produced by VidCutter so far: They had a .vcp extension, but contained EDL data. The new parser regex handles this gracefully.