fix: prevent sending messages with attachments multiple times by adding current state check #3100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This will be tracked internally on Jira (SES-1939) for code review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First time contributor checklist:
Contributor checklist:
clearnetbranchyarn readyrun passes successfully (more about tests here)Description
I have tested issue described in #2744 and figured out that the problem was in onSendMessage() function taking long time to complete (and thus reset composition box input) because of getFiles() async function which scales and stores attachments locally before sending.
I have added a simple check to CompositionBoxInner class that prevents user from sending multiple messages. I think the best solution would be to move all attachments logic to sending stage so that visually messages would be sent immediately, but I didn't want to change a lot of logic.
Related: #2744