-
Notifications
You must be signed in to change notification settings - Fork 21
Make Gap duration adjustable #77
base: master
Are you sure you want to change the base?
Conversation
I managed to get an element added and it displays the correct duration length of the gap. But when I edit nothing update, wondered if I could have some pointers as to how I would adjust the duration of the gap? I tried to copy *edit: looks like it would live in here? komposition/src/Komposition/Application/TimelineMode.hs Lines 190 to 196 in f4db3f0
|
sorry rubber ducking here 🦆 |
Just took another look at this and noticed that "start end" is implemented for the audio as of yet so I won't be able to add this feature to audio gap without implementing that first. I also can't seem to find a test case where this would live 🤷♀️ |
OK, so this would need to use the new undo/redo machinery now, but there are examples already (setting duration of a clip). Would you mind rebasing the PR and implementing it in |
yeah not a problem will take a look this evening, I assume the new functionality came in this PR #82 ? |
@Cmdv that's right 👍 |
Description:
This pull requests fixes #69
Make sure to describe (where applicable):
Checklist:
Please make sure to check the following items (that are applicable.)
How to test:
add video gap, select gap and on the sidebar adjust it's duration.
TODO: Testing instructions for reviewer.