Skip to content
This repository has been archived by the owner on Jul 28, 2021. It is now read-only.

Make Gap duration adjustable #77

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Make Gap duration adjustable #77

wants to merge 4 commits into from

Conversation

Cmdv
Copy link
Contributor

@Cmdv Cmdv commented Jan 8, 2019

Description:

This pull requests fixes #69

Make sure to describe (where applicable):

  • The ability to adjust the gap duration in the sidebar

screenshot 2019-01-08 at 22 13 59

Checklist:

Please make sure to check the following items (that are applicable.)

  • Doesn't duplicate any existing PR
  • Automated tests added
  • Includes relevant user guide/documentation changes

How to test:
add video gap, select gap and on the sidebar adjust it's duration.

TODO: Testing instructions for reviewer.

@Cmdv
Copy link
Contributor Author

Cmdv commented Jan 8, 2019

I managed to get an element added and it displays the correct duration length of the gap. But when I edit nothing update, wondered if I could have some pointers as to how I would adjust the duration of the gap?

I tried to copy clipSpanControl but it looks like it uses VideoAsset which is on the type but this is non existent on VideoGap, does this have something to do with it?

*edit: looks like it would live in here?

FocusedClipStartSet start ->
model
& modifyFocusedVideoPart (\case
VideoClip ann asset ts speed ->
VideoClip ann asset ts { spanStart = start } speed
vg@VideoGap{} -> vg)
& refreshPreviewAndContinue gui

@Cmdv
Copy link
Contributor Author

Cmdv commented Jan 9, 2019

sorry rubber ducking here 🦆
Got the VideoGap state to update so this all works just need to do this to audio gap to then tests 😄

@Cmdv
Copy link
Contributor Author

Cmdv commented Jan 19, 2019

Just took another look at this and noticed that "start end" is implemented for the audio as of yet so I won't be able to add this feature to audio gap without implementing that first.

I also can't seem to find a test case where this would live 🤷‍♀️

@Cmdv Cmdv changed the title Make Gap duration adjustable - WIP Make Gap duration adjustable Jan 19, 2019
@owickstrom
Copy link
Owner

OK, so this would need to use the new undo/redo machinery now, but there are examples already (setting duration of a clip). Would you mind rebasing the PR and implementing it in UndoableAction? Totally get if you don't, I can move it otherwise.

@Cmdv
Copy link
Contributor Author

Cmdv commented Feb 14, 2019

yeah not a problem will take a look this evening, I assume the new functionality came in this PR #82 ?

@owickstrom
Copy link
Owner

@Cmdv that's right 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make gap duration adjustable in sidebar
2 participants