Feature/refactor relative epsilon #602
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #602 +/- ##
==========================================
- Coverage 88.16% 88.15% -0.01%
==========================================
Files 74 74
Lines 7764 7753 -11
Branches 544 542 -2
==========================================
- Hits 6845 6835 -10
+ Misses 778 777 -1
Partials 141 141
|
change pydocs
marcocuturi
approved these changes
Nov 29, 2024
| import jax.numpy as jnp | ||
| import jax.tree_util as jtu | ||
|
|
||
| __all__ = ["Epsilon", "DEFAULT_SCALE"] | ||
|
|
||
| #: Scaling applied to statistic (mean/std) of cost to compute default epsilon. | ||
| DEFAULT_SCALE = 0.05 |
There was a problem hiding this comment.
I think we should move DEFAULT_SCALE to geometry.py since this is where it's used? maybe also change its name? I could suggest DEFAULT_EPSILON_SCALE
| **kwargs | ||
| } | ||
| return Epsilon(**kwargs) | ||
| def __repr__(self) -> str: |
| cost_fn: a CostFn function between two points in dimension d. | ||
| x: Array of shape ``[n, d]``. | ||
| y: Array of shape ``[m, d]``. If :obj:`None`, use ``x``. | ||
| cost_fn: Cost function between two points in dimension :math:`d`. | ||
| batch_size: When ``None``, the cost matrix corresponding to that point cloud |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@marcocuturi could you please update the documentation?
closes #478