Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ground truth pose publishers should not publish static TFs #607

Open
peci1 opened this issue Sep 14, 2020 · 3 comments · May be fixed by #759
Open

Ground truth pose publishers should not publish static TFs #607

peci1 opened this issue Sep 14, 2020 · 3 comments · May be fixed by #759
Labels
enhancement New feature or request

Comments

@peci1
Copy link
Collaborator

peci1 commented Sep 14, 2020

In all robot models, e.g.

<publish_nested_model_pose>#{$enableGroundTruth}</publish_nested_model_pose>
<use_pose_vector_msg>true</use_pose_vector_msg>
<static_publisher>true</static_publisher>

the ground truth pose is published as a static TF. It works, but it's not right, because static TFs should only be used for transforms that do not change or change only occasionally.

I think it could be fixed by adding this snippet to all robots:

    <plugin filename="libignition-gazebo-pose-publisher-system.so"
        name="ignition::gazebo::systems::PosePublisher">
        <publish_link_pose>false</publish_link_pose>
        <publish_sensor_pose>false</publish_sensor_pose>
        <publish_collision_pose>false</publish_collision_pose>
        <publish_visual_pose>false</publish_visual_pose>
        <publish_nested_model_pose>#{$enableGroundTruth}</publish_nested_model_pose>
        <use_pose_vector_msg>true</use_pose_vector_msg>
        <static_publisher>false</static_publisher>
      </plugin>

and setting

    <publish_nested_model_pose>false</publish_nested_model_pose>

in the static transform snippets.

@nkoenig nkoenig added the enhancement New feature or request label Sep 16, 2020
@acschang
Copy link
Contributor

Related to #659

@peci1 peci1 linked a pull request Jan 19, 2021 that will close this issue
@peci1
Copy link
Collaborator Author

peci1 commented Jan 19, 2021

Solution proposed in #759.

@iche033
Copy link
Contributor

iche033 commented Mar 5, 2021

the changes look good to me and would resolve the issue that model poses are incorrectly published to the pose_static topic.

This makes me think that the PosePublisher system should really just be classifying a model / nested model entity as a dynamic entity instead of a static one (in which case, we would just insert the entity into the dynamic entities list somewhere around here, i.e. if (nestedModel) this->dynamicEntities.insert(entity))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
4 participants