Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix retaining disabled ROM apps in some cases again #25

Merged
merged 1 commit into from
Nov 1, 2024

Conversation

Rev4N1
Copy link

@Rev4N1 Rev4N1 commented Oct 30, 2024

At least on my setup on first install it was disabling correctly, on reflash/update the module stopped disabling and if I reflashed it was disabled again.

I'm disabling an app inside system_ext

On KernelSU and I am guessing also APatch on first install before reboot the folder for disabling is created inside "$MODPATH/system":

ls -l /data/adb/modules_update/playintegrityfix/system
drwxr-xr-x    3 root     root          4096 Oct 30 23:01 system_ext

After rebooting, the folder gets moved to the root of the module and a system link is generated:

ls -l /data/adb/modules/playintegrityfix/system
lrwxrwxrwx 1 root root 13 2024-10-30 23:01 system_ext -> ../system_ext

ls -l /data/adb/modules/playintegrityfix/system_ext
drwxr-xr-x 4 root root 4096 2024-10-30 23:01 app

So if you don't copy the referenced folder instead of the syslink after the reflash and rebooting, the syslink will be pointing into a missing folder.

I tested this on KernelSU and Magisk and on my end everything holds correctly.

I'm also removing the -r because its implicit in -a

@osm0sis
Copy link
Owner

osm0sis commented Nov 1, 2024

Thanks for another great contribution! This was the last thing I had on my to-do list to look into before v12 actually, but you beat me to it! 😃

The tester I had lined up confirmed it working with Xiaomi.eu and APatch. 🤘

We can call CI # 339 340 a release candidate unless you've got some other improvements in mind. 👍

@osm0sis osm0sis merged commit 1edc85d into osm0sis:main Nov 1, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants