Fix retaining disabled ROM apps in some cases again #25
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At least on my setup on first install it was disabling correctly, on reflash/update the module stopped disabling and if I reflashed it was disabled again.
I'm disabling an app inside system_ext
On KernelSU and I am guessing also APatch on first install before reboot the folder for disabling is created inside "$MODPATH/system":
After rebooting, the folder gets moved to the root of the module and a system link is generated:
So if you don't copy the referenced folder instead of the syslink after the reflash and rebooting, the syslink will be pointing into a missing folder.
I tested this on KernelSU and Magisk and on my end everything holds correctly.
I'm also removing the -r because its implicit in -a