Skip to content

Commit

Permalink
Don't coexist with those who behave inappropriately
Browse files Browse the repository at this point in the history
  • Loading branch information
@osm0sis
osm0sis authored Oct 19, 2024
1 parent 7dd9ed8 commit 565d895
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions module/common_setup.sh
View file
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,12 @@ if [ -d /data/adb/modules/safetynet-fix ]; then
touch /data/adb/modules/safetynet-fix/remove
ui_print "! Universal SafetyNet Fix (USNF) module will be removed on next reboot"
fi
for BADMOD in playcurl playcurlNEXT; do
if [ -d /data/adb/modules/$BADMOD ]; then
touch /data/adb/modules/$BADMOD/remove
ui_print "! $BADMOD module will be removed on next reboot"
fi
done

# Replace/hide conflicting custom ROM injection app folders/files to disable them
LIST=$MODPATH/example.app_replace.list
Expand Down

5 comments on commit 565d895

@daboynb
Copy link

@daboynb daboynb commented on 565d895 Oct 21, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’ve edited this message because I noticed that my previous tone came off as too arrogant, which was not my intention.

I want to clarify that credits were given when necessary, and they were included in the README file the first time I used migrate.sh months ago.

Here’s the relevant link for reference: https://t.me/PifNEXT/53

@osm0sis
Copy link
Owner Author

@osm0sis osm0sis commented on 565d895 Oct 21, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for finally reaching out, however a 1 line README doesn't satisfy the GPL. If you want to add the acknowledgement in your playcurlNEXT README for my work you've been using in the playcurl-autojson backend, then add the GPLv3 license to your autojson repo to comply with its terms, then we're square and I'll happily remove you from the forced removal list.

I hope you can see why the lack of visible credit and proper licensing has been frustrating for me, while people continue to just copy/paste things from my work and in effect pass it off as their own work.

And for the record not a single line of your autojson script was in my original autopif. The beef there was you hard forking PIF and removing all commit history/attribution from @chiteroman, myself and others, so, again, about you not providing proper credit and complying with the license.

You may want to have a similar conversation with @chiteroman, who's had this in PIF for quite awhile:
https://github.com/chiteroman/PlayIntegrityFix/blob/main/module/customize.sh#L18

@daboynb
Copy link

@daboynb daboynb commented on 565d895 Oct 21, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not an English native speaker but I'll try my best trying to let you understand this.

There’s a difference between saying I didn’t give credit and saying I didn’t do it properly according to GPLv3.

Yesterday, I had to post to explain to people that credits were given and post links.

I would have appreciated being informed about what was incorrect, rather than hearing people saying I didn’t give credits at all.

Anyway, yesterday I added GPLv3 (it was only on the random branch, I've added it on main too now).

When I created PlayIntegrityNext, I forked chiteroman’s work, and it seemed pretty clear to me what the base was.

I didn’t make a repo without saying anything and copying it, I used the “fork” button for a reason.

For the part about the commits, I didn’t know it was relevant. I always remove the history so I know when my work started, and it’s easier for me to make changes. I didn’t think it would be an issue for GPLv3.

So, I’ve always given credit, maybe not in the correct way? Sure, and I’ll fix it, but I want to point out that I’ve never taken anything without specifying in the README from whom it was forked.

Forking the repo if the codebase was someone else’s has always been my practice.

I didn’t want to be angry, but it made me upset reading people saying, “Oh, he’s right, he stole the code.”

It was very frustrating reading that after I’ve always written credits. Again, I’ll do better.

@osm0sis
Copy link
Owner Author

@osm0sis osm0sis commented on 565d895 Oct 21, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I absolutely give you credit for having had that acknowledgement in your autojson README since the beginning, it just always felt a little intentionally less visible on that repo which the average person won't know is the beating heart of your playcurl projects.

As for providing acknowledgement and commit histories, I do agree that those are more "proper etiquette" things in good faith development and not the letter of the GPL, but again, the intentional removal of the commit history seemed outwardly like a choice to obscure/avoid giving credit. Sorry if I misunderstood your intentions there and reacted strongly by writing the original autopif.

I do see you've now made both playcurlNEXT and autojson repos GPLv3 and updated the acknowledgement in the autojson repo, so thank you for taking those steps. If you could add some minor further acknowledgement in your playcurlNEXT README that it uses your autojson repo and therein some of my work, that would also be greatly appreciated as proper etiquette. I'll happily revert the forced removals from PIFork when I'm home from work later today. 👍

@daboynb
Copy link

@daboynb daboynb commented on 565d895 Oct 21, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added a better description on both the repos, happy to hear that the issue has been solved. 👍

Please sign in to comment.