Introduce ServerId type, use it in MsgSource and MsgTarget #378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow connecting to same server multiple times, fixing #374.
I implemented the plan as described in #374 (comment).
This currently does not build -- I need to update the logger crate. I'm not sure how to handle multiple servers with same name and same alias in the logger yet. It's probably best to reject such cases and ask the user to come up with a unique
server name, aliaspair.In principle, once we establish the invariant that
server name, aliaspairs are always unique, we no longer need theServerIdtype. In practice though it's easier (and more efficient) to compare integers (ServerId) than string pairs.So maybe it's best to make sure
(server name, alias)are unique (for to logger, TUI doesn't care), but keep theServerIdtype.