-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use perlcritic from os-autoinst-common #5459
Open
b10n1k
wants to merge
1
commit into
os-autoinst:master
Choose a base branch
from
b10n1k:perlcritic_config
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
okurz
requested changes
Feb 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/perlcritc/perlcritic/
b10n1k
force-pushed
the
perlcritic_config
branch
from
February 7, 2024 10:22
6607220
to
f68707d
Compare
b10n1k
changed the title
Use perlcritc from os-autoinst-commom
Use perlcritrc from os-autoinst-commom
Feb 7, 2024
b10n1k
changed the title
Use perlcritrc from os-autoinst-commom
Use perlcritic from os-autoinst-commom
Feb 7, 2024
b10n1k
force-pushed
the
perlcritic_config
branch
from
February 9, 2024 07:29
f68707d
to
3d14585
Compare
I update the os-autoinst-common as the checkstyle keeps failing #5465 |
s/commom/common/ |
kalikiana
approved these changes
Feb 9, 2024
@b10n1k Please consider this open suggestion, and there is a CI check failing:
Maybe consider os-autoinst/os-autoinst-common#42 here?
|
b10n1k
changed the title
Use perlcritic from os-autoinst-commom
Use perlcritic from os-autoinst-common
Feb 15, 2024
b10n1k
force-pushed
the
perlcritic_config
branch
from
February 15, 2024 21:38
3d14585
to
e126112
Compare
OpenQA is ready for adapt the perlcriticrc from os-autoinst-common. https://progress.opensuse.org/issues/138416 Signed-off-by: ybonatakis <ybonatakis@suse.com>
b10n1k
force-pushed
the
perlcritic_config
branch
from
February 15, 2024 21:39
e126112
to
6ac8883
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OpenQA is ready for adapt the perlcriticrc from os-autoinst-common.
https://progress.opensuse.org/issues/138416