Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small change on line 343 and line 345. #5044

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

debrajnath
Copy link

Added a few words for better context to help the reader understand more clearly.

Added a few words for better context to help the reader understand more clearly.
@github-actions
Copy link

Great PR! Please pay attention to the following items before merging:

Files matching docs/*.asciidoc:

  • Consider generating documentation locally to verify it is rendered correctly using tools/generate-htmldoc

This is an automatically generated QA checklist based on modified files.

@@ -340,9 +340,9 @@ The personal configuration should be stored in a file
the `client.conf`, i.e. sections for each machine, e.g. `localhost`.

[[get-testing]]
== Testing openSUSE or Fedora
== Testing openQA on openSUSE or Fedora
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This completely reverses meaning of title,

This isn't about testing openQA on some distribution but about testing distro in openQA

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops! Sorry my fault. 😔

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you find it helpful you could phrase it the other way around:

Suggested change
== Testing openQA on openSUSE or Fedora
== Testing openSUSE or Fedora with openQA

Copy link
Contributor

@Martchus Martchus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, but I think the intended meaning is really to test openSUSE or Fedora themselves. The idea is to use the existing test distributions for testing those operating systems to get started with running some tests on your openQA setup. Maybe it would still make sense to be more explicit about this.

Note that we can also not accept your commits because of the commit message. Start with a verb in imperative and don't put a . at the end, e.g. "Improve wording in documentation for getting started".

@stale
Copy link

stale bot commented Jun 17, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jun 17, 2023
@stale stale bot removed stale labels Jul 18, 2023

An easy way to start using openQA is to start testing openSUSE or Fedora as they
An easy way to start using openQA is to start testing on openSUSE or Fedora as they
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
An easy way to start using openQA is to start testing on openSUSE or Fedora as they
An easy way to start using openQA is to run openSUSE or Fedora tests as they

Copy link

stale bot commented Mar 17, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Mar 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants