Merge pull request #5461 from Martchus/next-and-previous

Avoid sporadic failures in `t/ui/16-tests_job_next_previous.t`

t/lib/OpenQA/SeleniumTest.pm

@@ -314,11 +314,13 @@ sub wait_until_element_gone ($selector, @args) {
 sub wait_for_element (%args) {
     my $selector = $args{selector};
     my $expected_is_displayed = $args{is_displayed};
+    my $trigger_function = $args{trigger_function};
     my $method = $args{method} // $find_method;
 
     my $element;
     wait_until(
         sub {
+            $trigger_function->() if $trigger_function;
             my @elements = $_driver->find_elements($selector, $method);
             if (scalar @elements >= 1
                 && (!defined $expected_is_displayed || $elements[0]->is_displayed == $expected_is_displayed))

t/ui/16-tests_job_next_previous.t

@@ -78,8 +78,10 @@ driver_missing unless my $driver = call_driver;
 disable_timeout;
 
 sub goto_next_previous_tab {
-    $driver->find_element('#nav-item-for-next_previous')->click();
-    wait_for_element(selector => '.dataTables_wrapper');
+    wait_for_element(
+        trigger_function => sub { $driver->find_element_by_link_text('Next & previous results')->click },
+        selector => '.dataTables_wrapper'
+    );
     wait_for_ajax(msg => 'Next & previous table ready');
 }