Add an API to fetch all event handlers #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
villat
reviewed
Jan 4, 2024
|
|
||
| @Override | ||
| public void handleIncomingEvent(Map<String, Object> payload) { | ||
| this.eventResourceApi.handleIncomingEvent(payload); |
There was a problem hiding this comment.
Nit: here you're calling it as this.eventResourceApi and above just eventResourceApi
villat
reviewed
Jan 4, 2024
| import org.apache.commons.lang.StringUtils; | ||
|
|
||
| import com.netflix.conductor.common.metadata.workflow.*; |
There was a problem hiding this comment.
I know isn't your change, but we shouldn't use wildcard imports
There was a problem hiding this comment.
There is a spotless plugin that mandates this.
dilip-lukose
approved these changes
Jan 4, 2024
v1r3n
approved these changes
Jan 4, 2024
villat
approved these changes
Jan 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.