Roll iotam and iota deployments if config has changed #93
Conversation
- increased iot-agent-manager version in values - use mongo service name directly instead of specifying each member at once (iotam 1.13.0 supports this) in values
|
#97 will fix the build mechanism, once merged, you should rebase if everything works fine, we will then merge ;) |
|
@modularTaco #97 just got merged, if you could please rebase on master, thanks alot!! |
|
@modularTaco thanks for your pr, that's great. the helm linter is moaning about some missing newlines at the end of some files---see linter errors. if you could please fix that, thanks soooo much! |
| @@ -37,7 +37,7 @@ mongo: | |||
| # The name of the replicaset iot-agent will attempt to connect to | |||
| rs: rs | |||
| # The hostname of the mongodb service | |||
| dbhost: mongo-rs-mongodb-replicaset-0.mongo-rs-mongodb-replicaset.prod,mongo-rs-mongodb-replicaset-1.mongo-rs-mongodb-replicaset.prod,mongo-rs-mongodb-replicaset-2.mongo-rs-mongodb-replicaset.prod | |||
| dbhost: mongo-rs-mongodb-replicaset.prod | |||
There was a problem hiding this comment.
@c0c0n3 Unfortunately i'm not using IOTA and IOTAM anymore and this PR is quite old, so i do not remember completely. But there is something in the back of my mind that this change was not as flawless as it should be and we ran into some problems with it. Could you please doublecheck that using the servicename instead of the members seperately is supported and works fine with mongo pod restarts?
There was a problem hiding this comment.
@modularTaco thanks for the heads up, much appreciated! we'll review and retest to see if there are any issues
|
hi @modularTaco
yep, it looks like everything is hunky-dory now, fan-tas-tic!!
no prob, I've seen your comment. we'll review and retest to see if there are any issues. thanks alot! |
apps/v1beta1withapps/v1in autoscaler