Refactor sqlsync react #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@matthewgapp can you take a look at this PR and let me know if it looks ok to you? Ideally it dramatically simplifies the SolidJS PR. I haven't finished integrating this with demo/frontend yet so it's still marked as a draft. Will finish that up tomorrow along with any comments you have. |
|
Ok fixing the frontend wasn't very difficult. Will finish this up tomorrow. |
Looks gr8! I rebased my PR onto this branch and tested it. Seems to be working! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors sqlsync-react and sqlsync-worker in order to move most of the generic code out of sqlsync-react and into sqlsync-worker. The goal of this PR is to make it easier to build more framework specific libraries such as support for SolidJS (see #37).