Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove a MatplotlibDeprecationWarning #129

Draft
wants to merge 1 commit into
base: 5.x
Choose a base branch
from
Draft

Conversation

sphh
Copy link

@sphh sphh commented Jun 2, 2021

Remove this warning:

…/geomdl/visualization/VisMPL.py:431: MatplotlibDeprecationWarning: Axes3D(fig) adding itself to the figure is deprecated since 3.4. Pass the keyword argument auto_add_to_figure=False and use fig.add_axes(ax) to suppress this warning. The default value of auto_add_to_figure will change to False in mpl3.5 and True values will no longer work in 3.6. This is consistent with other Axes classes.
ax = Axes3D(fig)

Remove this warning:

…/geomdl/visualization/VisMPL.py:431: MatplotlibDeprecationWarning: Axes3D(fig) adding itself to the figure is deprecated since 3.4. Pass the keyword argument auto_add_to_figure=False and use fig.add_axes(ax) to suppress this warning. The default value of auto_add_to_figure will change to False in mpl3.5 and True values will no longer work in 3.6.  This is consistent with other Axes classes.
  ax = Axes3D(fig)
@orbingol
Copy link
Owner

orbingol commented Jun 2, 2021

geomdl 5.x still supports python 2.7.x (I know it is EOL but academic apps usually require compatibility with EOL software). I don't think MPL 3.4 supports py2.7. For now, please use a MPL version < 3.4

I will be deprecating 2.7.x support in geomdl 6.x along with several other major changes.

@orbingol orbingol marked this pull request as draft June 2, 2021 20:51
@sphh
Copy link
Author

sphh commented Jun 2, 2021

Ok, I can see your point. But I am already at MPL 3.4.2 and do not want / cannot downgrade. Oh, I guess, I have to live with that warning then (or apply these changes to my local copy :-o )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants