Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Corrects missing is_shareable attribute in results from data source oci_core_volume_attachments #2191 #2197

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Corrects missing is_shareable attribute in results from data source oci_core_volume_attachments #2191 #2197

wants to merge 1 commit into from

Conversation

jeliker1
Copy link

Data source oci_core_volume_attachments is missing is_shareable attribute so that it returns false for all results. This change adds the missing attribute and updates related documentation to indicate inclusion of the attribute.

@jeliker1
Added missing is_shareable attribute for data source `oci_core_volu…
afefe34 
…me_attachments` ref oracle#2191

Update data source documentation for `oci_core_volume_attachments`

Signed-off-by: Jon-Eric Eliker <jeliker@mythics.com>
@oracle-contributor-agreement Oracle Contributor Agreement
Copy link

Thank you for your pull request and welcome to our community! To contribute, please sign the Oracle Contributor Agreement (OCA).
The following contributors of this PR have not signed the OCA:

To sign the OCA, please create an Oracle account and sign the OCA in Oracle's Contributor Agreement Application.

When signing the OCA, please provide your GitHub username. After signing the OCA and getting an OCA approval from Oracle, this PR will be automatically updated.

If you are an Oracle employee, please make sure that you are a member of the main Oracle GitHub organization, and your membership in this organization is public.

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Required At least one contributor does not have an approved Oracle Contributor Agreement. label Sep 19, 2024
@tf-oci-pub tf-oci-pub added the Pending Test Pending Test label for PRs label Sep 20, 2024
@tf-oci-pub
Copy link
Member

Thank you for your valuable contribution. We greatly appreciate your efforts in submitting this pull request. However, I regret to inform you that we are unable to merge it directly on GitHub at this time.

Our internal policy requires that all pull requests undergo thorough local testing and review before they can be merged into the main codebase. This process ensures the quality and stability of Terraform-Provider-OCI.

We understand that this may cause some inconvenience, but please rest assured that your contribution is highly valued. Our team will carefully review and test your changes locally to ensure they meet our standards.

We appreciate your understanding and patience in this matter. If you have any questions or need further assistance, please don't hesitate to reach out. Thank you once again for your contribution.

@oracle-contributor-agreement Oracle Contributor Agreement
Copy link

Thank you for signing the OCA.

@oracle-contributor-agreement oracle-contributor-agreement bot added OCA Verified All contributors have signed the Oracle Contributor Agreement. and removed OCA Required At least one contributor does not have an approved Oracle Contributor Agreement. labels Sep 24, 2024
@jeliker1
Copy link
Author

@tf-oci-pub hoping someone has opportunity for review. I think the change is quite simple and logical making me think the review ought to be a low-effort task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement. Pending Test Pending Test label for PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeliker1 @tf-oci-pub