levelset: rework overall design #422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrea-iob
force-pushed
the
levelset.cache
branch
from
45f0d83
to
638036c
Compare
andrea-iob
force-pushed
the
levelset.cache
branch
from
638036c
to
62dfd28
Compare
andrea-iob
force-pushed
the
levelset.cache
branch
2 times, most recently
from
7ad8f62
to
6751186
Compare
andrea-iob
force-pushed
the
levelset.cache
branch
from
6751186
to
f0dc451
Compare
andrea-iob
force-pushed
the
levelset.cache
branch
3 times, most recently
from
e2d7ff6
to
c473bdb
Compare
|
The final implementation is not 100% compatible with the current version. The names of a couple of classes have changed, but, overall, I think that adapting an existing code to the new implementation should be easy. |
andrea-iob
force-pushed
the
levelset.cache
branch
2 times, most recently
from
4f3cfee
to
e038aa8
Compare
…r Cartesian meshes Intersections between mesh bounding box and segments should be performed without inflating the bounding box of the mesh.
The initialization of the constructor is now handled by the kernel object itself.
Immutable objects were introduced to reduce the memory footprint of the levelset. In the next commits a different strategy for reducing the memory reduced by the levelset will be introduced.
The main purpose of the rework is to reduce the memory footprint of the
levelset. To achieve this goal, the values computed by the levelset are
stored in separate caches. Each cache can be enabled separately form the
other and can operate in one of the following modes:
values can be cached as their are evaluated;
values can be pre-computed inside the narrow band;
values can be pre-computed on the whole domain.
When no caches are enabled, the only memory used by the levelset is the
memory that each object uses to store its own information (for example
the object that evaluates the levelset of a segmentation stored
information about the normals of the segmentation).
When no cached are enabled, the evaluation of the levelset is thread
safe and this allows to use the levelset object inside parallel OpenMP
regions.
andrea-iob
force-pushed
the
levelset.cache
branch
from
e038aa8
to
80893e9
Compare
|
I fixed a problem with the update of empty objects. Hopefully, this should address the last problems we had with this branch. |
marcocisternino
approved these changes
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main purpose of the rework is to reduce the memory footprint of the levelset. To achieve this goal, the values computed by the levelset are stored in separate caches. Each cache can be enabled separately form the other and can operate in one of the following modes:
When no caches are enabled, the only memory used by the levelset is the memory that each object uses to store its own information (for example the object that evaluates the levelset of a segmentation stored information about the normals of the segmentation).
When no cached are enabled, the evaluation of the levelset is thread safe and this allows to use the levelset object inside parallel OpenMP regions.
This new levelset aims to be 100% compatible with the existing levelset. Some functions are now deprecated, but thay should still work as before.
The pull request is a draft, because more tests should be performed.