-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve Interfaces #28
base: main
Are you sure you want to change the base?
Conversation
BeArchiTek
commented
Nov 11, 2024
- Replace "legacy" Nodes InterfaceL2 and InterfaceL3 and transform them into Generics
- Add Physical Interfaces, Sub Interfaces, Lag Interfaces and Virtual Interface
default_value: true | ||
default_value: 1514 | ||
order_weight: 1300 | ||
- name: status |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As we can't edit dropdown on generic I don't know if we shouldn't put it in the actual node ... (even tho it's going to be duplicated ...)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can override in a node the dropdown by recreating the attribute with the keyword "inherited: true" to redefine the options.
I would let it in the generic, and people can override it afterwards if they need other options.
inherit_from: | ||
- DcimInterface | ||
- InterfaceLayer2 | ||
- InterfaceLayer3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But here your virtual interface could have both l2 and l3 configurations ... wondering if we shouldn't create multiple nodes for that
e.g.
virtual l2 interface
virtual l3 interface
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's a tradeoff, if you get 2 types (L2 and L3) for virtual, you may want to do it for other interfaces too, but if you then want to keep some relationships no too "wide", you will need to create other Generics, just for the sake of "grouping" some models together.