Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(storage/nvme): add nvme ctrl parameters #154

Merged
merged 2 commits into from
Nov 29, 2023

Conversation

artek-koltun
Copy link
Contributor

No description provided.

@artek-koltun artek-koltun force-pushed the feat-add-nvme-ctrl-parameters branch 2 times, most recently from 48a2d0e to 524c25e Compare November 28, 2023 13:02
Copy link

codecov bot commented Nov 28, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (329e7ea) 34.65% compared to head (084eeb7) 34.82%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #154      +/-   ##
==========================================
+ Coverage   34.65%   34.82%   +0.16%     
==========================================
  Files          27       27              
  Lines        1939     1944       +5     
==========================================
+ Hits          672      677       +5     
  Misses       1267     1267              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@artek-koltun artek-koltun marked this pull request as ready for review November 28, 2023 13:06
@artek-koltun artek-koltun requested a review from a team as a code owner November 28, 2023 13:06
pydpu/storage.py Outdated Show resolved Hide resolved
Copy link
Member

@glimchb glimchb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

inside

@artek-koltun artek-koltun force-pushed the feat-add-nvme-ctrl-parameters branch 2 times, most recently from 8b8f3e4 to 084eeb7 Compare November 29, 2023 06:38
Signed-off-by: Artsiom Koltun <artsiom.koltun@intel.com>
Signed-off-by: Artsiom Koltun <artsiom.koltun@intel.com>
Copy link
Member

@glimchb glimchb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@glimchb glimchb merged commit 91579e3 into opiproject:main Nov 29, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants